-
Notifications
You must be signed in to change notification settings - Fork 990
Trace node execution in cudf-polars #19895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 79 commits into
rapidsai:branch-25.12
from
TomAugspurger:tom/log-stats
Oct 2, 2025
Merged
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
cad2f48
Tracing node execution in cudf-polars
TomAugspurger fcf5531
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger 31606d1
Added tests
TomAugspurger 6ba1cc9
More careful with statistics
TomAugspurger 40dc34e
type fixes
TomAugspurger f7e3b72
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger 9c256ef
dead code
TomAugspurger 820680a
more types
TomAugspurger ad26c4e
Track nvml stats too
TomAugspurger 64da24a
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger c57f7a4
fixups
TomAugspurger 678bb6f
Packaging
TomAugspurger 7ecceda
private HAS_STRUCTLOG
TomAugspurger 3febbd6
docs
TomAugspurger 75ccbec
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger 4c34d39
fixes
TomAugspurger db57c2f
Import-time determination
TomAugspurger 1f45e00
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger 6069141
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger 5f8c76f
doc fix
TomAugspurger a45b930
Test coverage up
TomAugspurger 1849128
coverage subprocess config
TomAugspurger 479fbeb
Merge branch 'branch-25.10' into tom/log-stats
TomAugspurger a9a0897
coverage pragmas
TomAugspurger 375d96d
More coverage
TomAugspurger b8e64aa
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger a8886da
Fixes
TomAugspurger 3fd15a3
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger 2d18e40
Another attempt
TomAugspurger 5002359
Another attempt
TomAugspurger 178426f
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger 25d2331
add a separate run
TomAugspurger 9e008c0
Add a separate run
TomAugspurger e87722e
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger e3a6bcf
Revert "add a separate run"
TomAugspurger e2b92b0
Revert "Add a separate run"
TomAugspurger d285979
filter logs
TomAugspurger 43ac2f6
set initial pool size
TomAugspurger 958face
Ensure buffers are freed, even during exceptions
TomAugspurger 8a6d4f8
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger d84d95a
remove duplicate code
TomAugspurger 4278cd1
Align ConditionalJoin.do_evaluate signature
TomAugspurger aba0fde
Only clear the frames if we're logging traces
TomAugspurger 3eaf54b
Use non-child args to pick out dataframes
TomAugspurger 351988f
remove print
TomAugspurger b5c17a6
More ConditionalJoin hacking
TomAugspurger 696951d
Remove unnecessary workaround
TomAugspurger 4d8d7b5
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger b79fc08
More memory adjustment
TomAugspurger 46b6cee
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger b988bf0
remove cov config change
TomAugspurger c79c808
Fix typing with Concatenate
TomAugspurger 96a1e65
Reuse bool_converter
TomAugspurger 6f105e2
Rename group to cudf_polars_trace
bdice 1d568bb
Use cudf_polars_trace dependency list in "all" list and test environm…
bdice 0ffc93f
Merge remote-tracking branch 'upstream/branch-25.10' into tom/log-stats
TomAugspurger e4391fc
Use `StatisticsResourceAdaptor` instead of cm
TomAugspurger 2be0ccd
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger f3fb7f8
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger 63f2170
import cleanup
TomAugspurger 0fe7fe4
Fix coverage pragma
TomAugspurger 409f5bb
Add fixture to cleare MR cache
TomAugspurger e05d085
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger fcf72dd
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger d14f433
Fix stale comment
TomAugspurger 54d23eb
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger 1889e2f
Merge branch 'branch-25.12' into tom/log-stats
TomAugspurger c5fc4c6
Merge branch 'branch-25.12' into tom/log-stats
TomAugspurger db916b7
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger c5f9c67
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger 6a5c5bd
fixes
TomAugspurger a4eb89e
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger a0efb2f
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger be92e9f
Cache the cachable
TomAugspurger 138ab2e
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger 355cc74
typo
TomAugspurger 23d4ebf
coverage
TomAugspurger e97b98e
Merge remote-tracking branch 'upstream/branch-25.12' into tom/log-stats
TomAugspurger bd9662f
doc fixes
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change, and the change to
do_evaluate, are to align with the other IR nodes whereself.non_child_argsmatchescls._non_chlidand the signature ofcls.do_evaluate, followed by dataframes.This lets get the dataframes passed to
do_evaluatebys slicing off the lastnvalues from args + kwargs, rather than introspecting the type of each value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel great about b5c17a6, but we have tests ensuring that
ConditionalJoinis picklable. Perhaps that's why this was different in the first place.