[5.x] Remove dependency on product model#57
Merged
Conversation
Member
|
I may be missing a bit of context, but aren't we using any product information to show the products currently in the wishlist? |
Collaborator
Author
All that data comes from ES. Any special data (like comments on individual products) come from the WishlistItem model itself. I triple checked to make sure, we don't use anything from the product model other than the SKU. |
indykoning
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
->withOnly([])on the product relation mostly did the trick, however this did not take care of any extra relations that may be added using global scopes. This gave me two other options to choose from:As it turned out, we only used the product model in this package to retrieve the SKU. This made the second option especially appealing for me in this case. In this PR, I've removed the product relation and kept it only as a join.