Fixed AttributeDecimal could not be converted to float#1243
Open
indykoning wants to merge 1 commit intomasterfrom
Open
Fixed AttributeDecimal could not be converted to float#1243indykoning wants to merge 1 commit intomasterfrom
indykoning wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
AttributeDecimal could not be converted to floatAfter the addition of the value, label, etc. functions on the attributes, this change here seems to have been forgotten.
This causes errors on the indexers and PDPs when products do not have their price in the product_price index, which seems to be the case when products are out of stock.