[4.x] Auto retry requests where the cart has expired#1236
Open
[4.x] Auto retry requests where the cart has expired#1236
Conversation
Jade-GG
commented
Mar 18, 2026
|
|
||
| return await window.magentoGraphQL( | ||
| query, | ||
| { ...variables, cartId: mask.value, cart_id: mask.value }, |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately some requests have cartId and others have cart_id. This was the simplest and most readable way to catch both.
indykoning
approved these changes
Mar 23, 2026
Member
indykoning
left a comment
There was a problem hiding this comment.
Code wise it's looking good.
But perhaps we can simplify it a lot by doing what we are doing in the useUser store:
core/resources/js/stores/useUser.js
Line 214 in 08c16ce
I reckon refreshing the cart after loading the page will tackle most of the problems users experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: RAP-1854, BORDEX-1358
Currently, when your cart expires you will sometimes get an ugly and scary error telling you your cart ID is not valid.
With this PR, I check for this error and underwater we retry the request once, adding a more friendly notification telling you that your cart has expired in the meantime. This means that, for example, if you add a product to your expired cart, it will make a new cart and then re-add the product to this new cart.
This makes the user experience for expired carts a bit nicer.