Fixed autoplay continuing on navigate, and muted getting removed on navigate#1233
Open
indykoning wants to merge 5 commits intomasterfrom
Open
Fixed autoplay continuing on navigate, and muted getting removed on navigate#1233indykoning wants to merge 5 commits intomasterfrom
indykoning wants to merge 5 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with videos when navigating using Turbo.
The first is the fact that the video will continue to auto play upon navigation using Turbo, even though the video no longer exists on the page. (hotwired/turbo-rails#147)
The second is that navigating back to a page with a muted video, the video will play unmuted (vuejs/core#6154)
Ref: FW-2310