[5.x] Don't show products without categories#1230
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: BORDEX-1361
I've made sure to double check. The
_exists_check didn't do anything except directly cause products without categories to be shown in every single category. We only add this filter when categoryId is set, so you don't end up with a(category_ids:)error.This also doesn't go wrong on search queries on a gibberish search within a category page (even if it did query an invalid field, which it won't because the query gets overwritten) nor does it go wrong on either ElasticSearch or OpenSearch.
From all the context I could find and test, there is no reason why this
_exists_should be here.