[4.x] Fix sorting of swatches & dropdown

[Jade-GG]

ref: GT-2514

This already works properly in 5.x because we sort on the attribute accessor. We can't do that here, it doesn't work if you sort in the query because json_objectagg has no defined order.

As such, we have to sort like this for just this once.

[royduin]

Maybe cleaner to have a custom cast for this: https://laravel.com/docs/master/eloquent-mutators#custom-casts and assign that in the CastSuperAttributes.php. Not sure if that's worth it for 4.x as we're already taken care of it in 5.x? Thoughts @indykoning?

[Jade-GG]

Maybe cleaner to have a custom cast for this: https://laravel.com/docs/master/eloquent-mutators#custom-casts and assign that in the CastSuperAttributes.php. Not sure if that's worth it for 4.x as we're already taken care of it in 5.x? Thoughts @indykoning?

Yeah I figured it's overkill to over-engineer something in an older version.

[royduin]

Merged, but still waiting for an approval by @indykoning