Add Proxmox Backup Server html_title fingerprint - #671
Open
ruashots wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
html_titlefingerprint for Proxmox Backup Server (PBS), which is currently unidentified. Its web UI (port 8007) serves<title>… - Proxmox Backup Server</title>, mirroring the existing Proxmox VE title fingerprint.Without it, a PBS host falls through to the shared Proxmox-family favicon fingerprint (
908db8e5…), which labels itVirtual Environment— a misidentification, since PBS, PVE, and PMG all serve that same favicon. The title is the disambiguating signal.^.{1,256} - Proxmox Backup Server$proxmox-backup-server - Proxmox Backup Server(verified against a live PBS 4.x instance)cpe:/a:proxmox:proxmox_backup_server:-(Side note for maintainers: the shared favicon entry asserting
Virtual Environmentspecifically may be worth demoting to vendor/family, since it can't distinguish PVE/PBS/PMG — happy to follow up separately.)