OTLP #283
Open
OTLP #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaegerExporter is deprecated. This would send traces using the OTLP over gRPC.
maximusunc
approved these changes
Nov 4, 2024
Contributor
maximusunc
left a comment
maximusunc
left a comment
There was a problem hiding this comment.
This all looks reasonable
changing default otlp endpoint host to be consistent with other apps, and to include http:// which seems to be necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JaegerExporter is dropping spans due to:
WARNING:opentelemetry.exporter.jaeger.thrift.send:Data exceeds the max UDP packet size
There are ways to fix that, but JaegerExporter is deprecated and we should replace it anyway. This PR would have aragorn send traces using the OTLPSpanExporter over gRPC instead.
It also updates some github actions versions, stopping the actions deprecation warnings.