wip: make Clover's instance interface to be matched with @solana/web3 #963

yeager-eren · 2024-12-02T12:29:31Z

Summary

We've been using .publicKey on Solana's instance which clover doesn't have. Tried to fix by using Proxy.

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

… and config change

- [email protected] Affected packages: [email protected] [skip ci]

…ALLET

- [email protected] Affected packages: [email protected] [skip ci]

…blockchain in the widget config

- [email protected] Affected packages: [email protected] [skip ci]

- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected] [skip ci]

… out of src

preparing legacy wallet management to be deprecated

this is part of preparation for our upcomin wallet management

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

- [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected] [skip ci]

- [email protected] Affected packages: [email protected] [skip ci]

…idget

- [email protected] Affected packages: [email protected] [skip ci]

- [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected] [skip ci]

- [email protected] Affected packages: [email protected] [skip ci]

- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected] [skip ci]

[skip ci]

chore: post release syncing

…fault.

Ikari-Shinji-re and others added 30 commits July 21, 2024 09:35

perf: improve token list performance by caching target tokens on load…

3cc55ff

… and config change

chore(release): publish

fdf7e13

- [email protected] Affected packages: [email protected] [skip ci]

fix: fix sort logic of notifications

ffcf4c2

chore(release): publish

ffcc421

- [email protected] Affected packages: [email protected] [skip ci]

feat: add preventable event and a new ui event called CLICK_CONNECT_W…

e4363bb

…ALLET

chore(release): publish

86eb974

- [email protected] Affected packages: [email protected] [skip ci]

feat: add the option to define a default custom destination for each …

7982ab6

…blockchain in the widget config

chore(release): publish

a2c7562

- [email protected] Affected packages: [email protected] [skip ci]

feat: add derivation path modal for trezor wallet

364422f

chore(release): publish

9f7f416

- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected] [skip ci]

chore: separating tsconfigs for being able to keep intergration tests…

810d638

… out of src

feat: accept multiple entrypoints for build script

2ef116f

chore: move wallet core files to legacy

bef621b

preparing legacy wallet management to be deprecated

chore: fix hoisting @types/web and conflicting with @types/dom

bd4dc78

chore: migrate wallets core and shared to nodenext module

3ed2d28

chore: move wallets react code to a subfolder called legacy

535fb74

this is part of preparation for our upcomin wallet management

chore: enable nodenext module system for wallets/react

fd7d863

chore(release): publish

270e7ff

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

feat: hide balance and max button when no wallet connected

80b2754

chore(release): publish

40229dc

- [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected] [skip ci]

fix: fix missing usd value in estimated output

a46d19a

chore(release): publish

8aaee05

- [email protected] Affected packages: [email protected] [skip ci]

feat: add functionality to update the quote inputs from outside the w…

d9722fb

…idget

chore(release): publish

f1df9ef

- [email protected] Affected packages: [email protected] [skip ci]

fix: fix bug in swap input handling empty value

3c9b082

chore(release): publish

e67b95a

- [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected] [skip ci]

chore: exclude tsconfig files from analyze bundle required artifacts

722eb5c

feat: add filter and clear to widget history

d43b603

nikaaru and others added 22 commits November 17, 2024 13:58

fix: fix error display for bad requests

82c0381

chore(release): publish

05a4063

- [email protected] Affected packages: [email protected] [skip ci]

chore: improve and document code splitting

d3142db

chore: update solana confirmation timeout

c7642ca

feat: display same source and destination token warning on widget

979cb0d

fix: improve ton signer and mytonwallet provider

7027755

chore(release): publish

e0aaef4

- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected] [skip ci]

feat: add ton connect provider

2a2dbb7

chore(translation): update translations [skip ci]

9d9f1b6

Merge branch 'next'

111ae52

chore(release): deploy

8522586

[skip ci]

Merge pull request #961 from rango-exchange/main

a7274d0

chore: post release syncing

feat: add an adapter for Hub for wallets-react and enabling Hub by de…

a14bdf9

…fault.

feat: add chain change subscribe to evm namespace

0a7e7ee

fix: fix frozen accounts array

5438438

fix: make Clover's instance interface to be matched with @solana/web3

3c4b222

yeager-eren requested a review from RanGojo as a code owner December 2, 2024 12:29

yeager-eren marked this pull request as draft December 2, 2024 12:29

yeager-eren deployed to app-preview December 2, 2024 12:40 — with GitHub Actions View deployment

yeager-eren deployed to playground-preview December 2, 2024 12:40 — with GitHub Actions View deployment

yeager-eren deployed to storybook-preview December 2, 2024 12:40 — with GitHub Actions View deployment

yeager-eren force-pushed the next branch from d05c245 to 3f2dfb9 Compare June 11, 2025 11:23

yeager-eren force-pushed the next branch 2 times, most recently from 9431967 to 6507542 Compare November 22, 2025 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

wip: make Clover's instance interface to be matched with @solana/web3 #963

wip: make Clover's instance interface to be matched with @solana/web3 #963

Uh oh!

yeager-eren commented Dec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

wip: make Clover's instance interface to be matched with @solana/web3 #963

Are you sure you want to change the base?

wip: make Clover's instance interface to be matched with @solana/web3 #963

Uh oh!

Conversation

yeager-eren commented Dec 2, 2024

Summary

How did you test this change?

Checklist:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants