Use ClusterClass in e2e for GKE provisioning#2177
Draft
furkatgofurov7 wants to merge 2 commits intorancher:mainfrom
Draft
Use ClusterClass in e2e for GKE provisioning#2177furkatgofurov7 wants to merge 2 commits intorancher:mainfrom
furkatgofurov7 wants to merge 2 commits intorancher:mainfrom
Conversation
furkatgofurov7
force-pushed
the
gcp-gke-clusterclass-e2e
branch
from
ea5a990 to
fd682ea
Compare
furkatgofurov7
added
kind/enhancement
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
furkatgofurov7
force-pushed
the
gcp-gke-clusterclass-e2e
branch
from
fd682ea to
27e872f
Compare
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A new example clusterclass was added, in line with the existing templates, and the cluster manifest in the test data directory was modified to use this new clusterclass.
GKE automatically upgrades the control plane during provisioning, causing
the Available condition to have a non-empty message about the upgrade in
progress. This is unavoidable GKE behavior and doesn't impact functionality
(the cluster successfully imports into Rancher).
Add SkipClusterAvailableWait flag to CreateUsingGitOpsSpecInput to allow
tests to skip the VerifyClusterAvailable check. Set this flag to true for
the GKE test case since the cluster is functional despite the upgrade state.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2084
Special notes for your reviewer:
Checklist: