-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Updated contents related to external TLS termination #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnwc
wants to merge
3
commits into
rancher:master
Choose a base branch
from
johnwc:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,15 +185,22 @@ You may terminate the SSL/TLS on a L7 load balancer external to the Rancher clus | |
|
||
Your load balancer must support long lived websocket connections and will need to insert proxy headers so Rancher can route links correctly. | ||
|
||
### Configuring Ingress for External TLS when Using NGINX v0.25 | ||
### Configuring Ingress for External TLS when Using NGINX | ||
|
||
In NGINX v0.25, the behavior of NGINX has [changed](https://github.com/kubernetes/ingress-nginx/blob/master/Changelog.md#0220) regarding forwarding headers and external TLS termination. Therefore, in the scenario that you are using external TLS termination configuration with NGINX v0.25, you must edit the `cluster.yml` to enable the `use-forwarded-headers` option for ingress: | ||
In the scenario that you are using external TLS termination configuration with NGINX, you must enable the `use-forwarded-headers` option for ingress: | ||
|
||
Create a `/var/lib/rancher/rke2/server/manifests/rke2-ingress-nginx-config.yaml` file with the following contents on one of your rke2 nodes. | ||
johnwc marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This assumes we're using RKE2 while this page doesn't seem to be RKE2 specific - the only occurrences of "RKE2" term are in added content. I think we should cover non-RKE2 cases as well. Adding @kinarashah as "all things NGINX" expert to review as well. |
||
```yaml | ||
ingress: | ||
provider: nginx | ||
options: | ||
use-forwarded-headers: 'true' | ||
apiVersion: helm.cattle.io/v1 | ||
kind: HelmChartConfig | ||
metadata: | ||
name: rke2-ingress-nginx | ||
namespace: kube-system | ||
spec: | ||
valuesContent: |- | ||
controller: | ||
config: | ||
use-forwarded-headers: "true" | ||
``` | ||
|
||
### Required Headers | ||
|
@@ -213,7 +220,7 @@ ingress: | |
|
||
Rancher will respond `200` to health checks on the `/healthz` endpoint. | ||
|
||
### Example NGINX config | ||
### Example NGINX config for your load balancer doing the TLS termination | ||
|
||
This NGINX configuration is tested on NGINX 1.14. | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.