Remove support for older Python version (#517) #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdimanteto
force-pushed
the
remove-older-python-versions-#517
branch
2 times, most recently
from
e7d4311 to
d841fee
Compare
joshdimanteto
force-pushed
the
remove-older-python-versions-#517
branch
8 times, most recently
from
9656409 to
137e5de
Compare
joshdimanteto
force-pushed
the
remove-older-python-versions-#517
branch
11 times, most recently
from
d2cf50d to
ec4350a
Compare
Author
|
use the latest 3.10 version in CI instead of 3.10.4 |
joshdimanteto
commented
Nov 5, 2025
joshdimanteto
commented
Nov 5, 2025
- remove downgrade of setuptools
Added `# noqa: B907` in several places where manual quoting is required for valid SQL query syntax. Using `!r` would change the format and break query parsing, so explicit quotes are necessary. This ensures tests and API calls remain correct while satisfying linting requirements.
- In the test_query_filter_factory the test don't work on the CI as it is not setting up the db backend.
joshdimanteto
force-pushed
the
remove-older-python-versions-#517
branch
from
04a2567 to
8673a50
Compare
VKTB
reviewed
Nov 12, 2025
Author
I'll leave this change for now, as this would change in the fast api upgrade |
VKTB
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #517
Description
see #517
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
closes #517
Notes
Upgraded poetry from 1.1.8 to 1.8.0. This is the maximum version that supports pydantic v2
Use fixture scope "function" for instead "package"