Move RusqliteExecutor and SQLite functions to common crate#2486
Open
Move RusqliteExecutor and SQLite functions to common crate#2486
Conversation
Relocate the executor and custom SQLite functions modules into crates/common/src/local_db so they can be reused outside the CLI. The CLI executor now re-exports from common. Also adds rusqlite with the functions feature as a regular dependency and switches the dev-dependency to tempfile.
Expose LocalDb and its constructor so external consumers can construct a LocalDb from a RusqliteExecutor. Add a non-wasm set_local_db method on RaindexClient for injecting the database.
Contributor
WalkthroughMoved the Rusqlite-backed local DB executor into the common crate, re-exported it from the CLI, exposed LocalDb and a setter on RaindexClient for non‑WASM, added rusqlite/tempfile dependencies, and adjusted module exports and small comment removals. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/common/Cargo.toml`:
- Line 81: Replace the direct version pin "tempfile = \"3\"" with a workspace
reference to match other crates; change the dependency entry so it uses
tempfile.workspace = true (i.e., convert the current tempfile dependency line to
the workspace-style declaration) to centralize version management and ensure
consistency with the CLI crate's tempfile.workspace = true usage.
ℹ️ Review info
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
crates/cli/Cargo.tomlcrates/common/Cargo.toml
| httpmock = "0.7.0" | ||
| rain_orderbook_test_fixtures = { workspace = true } | ||
| rusqlite = "0.31.0" | ||
| tempfile = "3" |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Use workspace reference for tempfile dependency.
The CLI crate uses tempfile.workspace = true (line 53 in crates/cli/Cargo.toml), but here a direct version is specified. For consistency and centralized version management, use the workspace reference.
♻️ Proposed fix
-tempfile = "3"
+tempfile = { workspace = true }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| tempfile = "3" | |
| tempfile = { workspace = true } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/common/Cargo.toml` at line 81, Replace the direct version pin
"tempfile = \"3\"" with a workspace reference to match other crates; change the
dependency entry so it uses tempfile.workspace = true (i.e., convert the current
tempfile dependency line to the workspace-style declaration) to centralize
version management and ensure consistency with the CLI crate's
tempfile.workspace = true usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
RusqliteExecutorand custom SQLite functions (float_is_zero,float_negate,float_sum,float_zero_hex) were previously confined to the CLI crate, making them inaccessible to other consumers in the workspace. Moving them to the common crate enables reuse across crates that need direct SQLite access with custom functions.Solution
RusqliteExecutorand all custom SQLite function modules fromcrates/cli/src/commands/local_db/tocrates/common/src/local_db/.RusqliteExecutorfrom common, preserving backwards compatibility.rusqlite(withfunctionsfeature) as a regular dependency in common; switchedrusqlitedev-dependency totempfile.LocalDband its constructor public so external consumers can construct aLocalDbfrom aRusqliteExecutor.set_local_dbmethod onRaindexClientfor injecting the database at runtime.#[cfg(not(target_family = "wasm"))].Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit
New Features
Refactor
Chores