Fix vault balance changes table not loading due to WASM race condition#2443
Open
Fix vault balance changes table not loading due to WASM race condition#2443
Conversation
Both VaultBalanceChart and VaultBalanceChangesTable were independently calling vault.getBalanceChanges(1) simultaneously, causing a race condition in the WASM layer where one call would return empty results. Lift the balance changes fetch to VaultDetail as a single source of truth and pass data down to both child components, making them pure display components.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a8de116 to
34a71b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The vault balance changes table on the vault details page was not loading any data. Both
VaultBalanceChartandVaultBalanceChangesTablewere independently callingvault.getBalanceChanges(1)simultaneously on mount, causing a race condition in the WASM layer where one call would return empty results while the other succeeded.Solution
Lift the balance changes data fetch into
VaultDetailas a singlecreateQuery, making it the single source of truth. Both child components become pure display components:createInfiniteQueryorTanstackAppTablecreateQueryfor balance changes, passes query to chart and data to tableThis eliminates the concurrent WASM call and simplifies the component architecture.
Checks
By submitting this for review, I'm confirming I've done the following: