Strip CLI to local-db only and remove unused dependencies#2440
Open
Strip CLI to local-db only and remove unused dependencies#2440
Conversation
Remove all CLI commands except local-db sync from the CLI crate. Remove the quote crate CLI module and binary entry point. Trim unused dependencies from both crates.
Contributor
WalkthroughThis PR removes the majority of CLI command functionality from the crate, including order, vault, trade, chart, quote, words, and subgraph commands, narrowing the public command surface to LocalDb only. Supporting infrastructure (Execute trait, output encoding, status display utilities, transaction/subgraph argument parsing) is also deleted. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~70 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The CLI has accumulated remote-based commands and quote CLI functionality that are no longer needed. This strips the CLI down to local-database operations only, removing ~6,000 lines of unused code.
Solution
order(add, remove, list, detail, calldata, compose, orderbook_address, listorderfrontmatterkeys),trade(list, detail),vault(deposit, detail, list, list_balance_changes, withdraw),chart,words, andsubgraphquoteCLI module (crates/quote/src/cli/)crates/cli/Cargo.tomlandcrates/quote/Cargo.tomlChecks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit