Skip to content

Flare v5 registry #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardyjosh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Flare v5 registry #2312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/webapp/src/lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const REGISTRY_URL =
'https://raw.githubusercontent.com/rainlanguage/rain.strategies/cf96aab81a59704ea8d9300130ac888eb86f5eff/registry';
'https://raw.githubusercontent.com/rainlanguage/rain.strategies/647695e7e374bf8411f5871f350d7d98ecde8bec/registry';
export const REMOTE_SETTINGS_URL =
'https://raw.githubusercontent.com/rainlanguage/rain.strategies/cf96aab81a59704ea8d9300130ac888eb86f5eff/settings.yaml';
'https://raw.githubusercontent.com/rainlanguage/rain.strategies/647695e7e374bf8411f5871f350d7d98ecde8bec/settings.yaml';
Comment on lines 1 to +4
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Include a screenshot showing the impact of the updated URLs.

This change modifies frontend constants that affect external resource loading in the webapp. Per the coding guidelines, frontend code modifications should include a screenshot of the built webapp reflecting the change.

As per coding guidelines.

🤖 Prompt for AI Agents 
In packages/webapp/src/lib/constants.ts lines 1-4, the reviewer requests a
screenshot showing the impact of the updated REGISTRY_URL and
REMOTE_SETTINGS_URL on the built webapp; reproduce the change by building and
running the webapp, navigate to a page that uses these external resources (or
the app's landing/dashboard showing loaded data), capture a clear screenshot
demonstrating successful resource loading (or visible differences/errors),
attach that screenshot to the PR (either upload in the PR description or add to
a docs/screenshots/ directory and reference it), and update the PR description
to mention which page was captured, the build commit used, and where the
screenshot is stored.

Comment on lines 3 to +4
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify settings.yaml accessibility and check if the duplicate constant needs updating.

The REMOTE_SETTINGS_URL has been updated consistently with REGISTRY_URL (both pointing to the same commit). However, based on learnings, this constant is intentionally duplicated in tauri-app/src/lib/services/loadRemoteSettings.ts. Please verify that:

  1. The settings.yaml file is accessible at the new URL
  2. The duplicate constant in the tauri-app file is also updated to maintain consistency

Based on learnings.

Run the following script to verify:

🏁 Script executed:

#!/bin/bash
# Verify settings.yaml accessibility and check for duplicate constant

# Test if the settings.yaml URL is accessible
echo "Checking settings.yaml URL accessibility..."
curl -f -s -o /dev/null -w "HTTP Status: %{http_code}\n" \
  'https://raw.githubusercontent.com/rainlanguage/rain.strategies/647695e7e374bf8411f5871f350d7d98ecde8bec/settings.yaml' || echo "Settings URL not accessible"

# Show first few lines of settings.yaml content
echo -e "\nSettings.yaml content preview:"
curl -s 'https://raw.githubusercontent.com/rainlanguage/rain.strategies/647695e7e374bf8411f5871f350d7d98ecde8bec/settings.yaml' | head -20

# Check if duplicate constant in tauri-app needs updating
echo -e "\nChecking tauri-app duplicate constant..."
if [ -f "tauri-app/src/lib/services/loadRemoteSettings.ts" ]; then
  echo "Content of tauri-app duplicate:"
  cat tauri-app/src/lib/services/loadRemoteSettings.ts | grep -A 1 "REMOTE_SETTINGS_URL"
else
  echo "tauri-app file not found in this repository"
fi

Length of output: 1015

Update duplicate REMOTE_SETTINGS_URL in tauri-app to match the new commit hash.

The settings.yaml file is accessible at the updated URL. However, the duplicate constant in tauri-app/src/lib/services/loadRemoteSettings.ts uses an outdated commit hash (cf96aab81a59704ea8d9300130ac888eb86f5eff) instead of the new one (647695e7e374bf8411f5871f350d7d98ecde8bec). This causes the webapp and tauri-app to fetch different versions of settings. Update the duplicate constant to maintain consistency:

const REMOTE_SETTINGS_URL =
  'https://raw.githubusercontent.com/rainlanguage/rain.strategies/647695e7e374bf8411f5871f350d7d98ecde8bec/settings.yaml';
🤖 Prompt for AI Agents 
In tauri-app/src/lib/services/loadRemoteSettings.ts (the location of the
REMOTE_SETTINGS_URL constant), update the duplicate constant value that
currently uses commit hash cf96aab81a59704ea8d9300130ac888eb86f5eff to the new
commit hash 647695e7e374bf8411f5871f350d7d98ecde8bec so the URL becomes
'https://raw.githubusercontent.com/rainlanguage/rain.strategies/647695e7e374bf8411f5871f350d7d98ecde8bec/settings.yaml',
ensuring both webapp and tauri-app fetch the same settings file.