refactor: replace HasMatch with HasFile for specific file paths #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fuzzy matching (HasMatch) with exact file path checks (HasFile) in all providers where specific files are being checked. This prevents false positives from glob pattern matching when checking for specific file names. Changes: - PHP provider: index.php, composer.json, artisan - Go provider: main.go, go.mod, go.work, go.sum, go.work.sum - Ruby provider: Gemfile, rails, bin/rails, config/environment.rb, config.ru, Rakefile - Node providers: package.json, lock files, config files for Vite, Astro, Angular, React Router - Python providers: main.py, requirements.txt, pyproject.toml, Pipfile, poetry.lock, pdm.lock, uv.lock, manage.py - Rust provider: Cargo.toml, src/main.rs, src/lib.rs - Elixir provider: mix.exs - Deno provider: deno.json, deno.jsonc, main.ts/js/mjs/mts - Java providers: gradlew, mvnw, gradle/maven wrapper properties - Staticfile provider: index.html, Staticfile config - Core: template.go and mise_step_builder.go Directory checks (e.g. src/bin, node_modules, public, script) continue to use HasMatch as they need pattern/directory matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace fuzzy matching (HasMatch) with exact file path checks (HasFile) in all providers where specific files are being checked. This prevents false positives from glob pattern matching when checking for specific file names.
Directory checks (e.g. src/bin, node_modules, public, script) continue to use HasMatch as they need pattern/directory matching.