feat: multimodule maven support #330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this, the correct jar won't exist in the final image
iloveitaly
commented
Nov 11, 2025
| | `RAILPACK_JDK_VERSION` | Override the JDK version | `17` | | ||
| | `RAILPACK_GRADLE_VERSION` | Override the Gradle version | `8.5` | | ||
|
|
||
| ## Multi-Module Projects |
Collaborator
Author
There was a problem hiding this comment.
@derkoe I don't have a lot of experience with Java. I'm curious what you think of this approach and if this makes sense for your particular use case.
Collaborator
Author
|
@coffee-cup This PR was very much LLM-inspired, as I have very little understanding or experience with Java. I'm not sure if you have more experience than I, but it would be great to get a second pair of eyes on this to make sure I'm not missing something obvious. |
coffee-cup
approved these changes
Nov 11, 2025
Contributor
coffee-cup
left a comment
coffee-cup
left a comment
There was a problem hiding this comment.
I am absolutely not the person to ask for Java stuff either :/
I would say good to merge as long as we have tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165