-
Notifications
You must be signed in to change notification settings - Fork 52
feat: C/C++ providers #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
coffee-cup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on combining the providers into a single one that switches based on how its built. Having 3 top level providers and docs pages is a lot for c++
Also do users who build with c++ typically deploy without any Dockerfile? I'm not familiar with the c++ world when it comes to servers, but worry these providers would get very low use and become out of date quickly. Is this something you actively deploy with?
|
Based on #164 and looking around based on that, it seems that Docker images are a relatively common way to package ROS packages, and normally that requires a decent bit of setup. As far as the other providers, I'd use the CMake provider. The Meson provider I'd probably also use, just not as often. They should all be relatively easy to keep up to date - the CMake and Meson providers default to just the latest versions, and so shouldn't require much maintenance at all, and all the ROS provider should need is an occasional base image update. As far as merging the providers, I'd be willing to do that for the Meson and CMake providers - the ROS provider, though, is a completely different beast, so I'd rather keep it separate. |
cfef57d to
1ae91eb
Compare
|
@aleksrutins thanks for your amazing work here and sorry for the delay! We decided not to support ROS. I'd never heard of it before—looks like a super cool framework—but I don't see a way any cloud provider is going host a ROS project. We should make it more clear that Railpack is focused on building containers for cloud deployment and not on-device images. The C++ provider looks great. If you can remove the ROS provider + docs, I can get the C++ support merged. |
|
Weirdly enough, the snapshots succeed on my machine. |
Closes #164
This PR adds a few providers: