Remove Bootsnap::CompileCache::JSON #508
Merged
+16
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that recent versions of the `json` gem are toe to toe with `msgpack`, there is little point in compiling JSON into msgpack. This also liekly mean msgpack could be improved, but even then, `json` is now fast enough. Co-Authored-By: Hartley McGuire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that recent versions of the
jsongem are toe to toe withmsgpack, there is little point in compiling JSON into msgpack.This also likely mean msgpack could be improved, but even then,
jsonis now fast enough.cc @skipkayhil