implement mapreduce for SkipMissingVal - #813
Closed
tiemvanderdeure wants to merge 1 commit into
Closed
tiemvanderdeure wants to merge 1 commit into
tiemvanderdeure wants to merge 1 commit into
Conversation
Collaborator
Author
|
ArchGDAL still segfaults on some resample. There is a PR that will fix this in Julia base and make this unnecessary: JuliaLang/julia#52397. So we can choose to wait it out. |
Owner
|
Oh maybe we can wait for base iterators to be fixed? This will break DiskArrays. And yes, it still segfaults. |
Owner
|
Lets close and wait for Base |
Collaborator
|
Should we recommend some more accurate summation algorithms in the meantime? Maybe in the |
Owner
|
Yeah possibly. Maybe when we allow online stats we can recommend that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementations is copy-pasted from Base, except that
ismissing(ai)is replaced by_missing(ai, itr)Solves #812
I'm not sure what this means for lazy rasters and chunked data from diskarrays. We might want to overload
IndexStylefor those? Let's see if tests pass.