fix(t3x): apply the sync test-timeout to every gate, not just fork CI - #32
Merged
Conversation
Follow-up to a393ff0, from an independent review of it. Three real defects, two of them regressions that commit introduced. 1. The timeout override never reached the pipeline that needs it most. a393ff0 fixed only t3x-ci.yml. The daily sync runs its own verify via scripts/t3x/sync-upstream.sh (`$RUN $script`, plain `vp run test`), and the resolver prompt tells the agent to run plain `vp run test` too. So the next upstream delta would rebase cleanly, fail verify on the exact test that was just diagnosed, and escalate as `verify-failed` — reopening issue #29's class of failure through a different door. Threaded through all three. 2. `--testTimeout=60000` silently HALVED apps/server's budget. apps/server/vite.config.ts pins testTimeout: 120_000, with a comment saying its sqlite+git+orchestration tests "can exceed the default budget on loaded CI hosts". The flag applies to every package, so 60s cut the heaviest suite in half — the same failure class the override exists to prevent. Now 120000, the highest value any package configures, so it lowers nothing: web 15s -> 120s, root 60s -> 120s, server 120s -> 120s. The old comment claiming it "only stops apps/web's override" was simply false. 3. Both SEAMS.md churn commands always returned 0. Git's approxidate silently ignores a relative suffix on an absolute date, so `--since="<iso> -60 days"` means `--since="<iso>"` — an empty window. The previous wrong-but-working command was replaced with two non-working ones, and since the doc says "if the ledger and this document disagree, the ledger is right", a literal regeneration would have zeroed every churn and risk figure. Now uses `--since="@<epoch>"` arithmetic, with the trap documented and a self-check value (ChatView should return ~59, not 0). Also corrects SEAMS.md against the tree a393ff0 actually created: merge-base b64ae88 (not 887dd6e), totals +1468/-112, claude.md row +78/-31. That commit edited a seam file without updating its own row, so a new rule says to update the row and totals in the same commit — the ledger measures the tree a commit creates, not the one it started from. Finally, records in the runbook that an upstream sync is the sanctioned exception to AGENTS.md's "do not run repo-wide checks" — a rebase can break any package, so the full suite is the point. Every file changed here is fork-owned, so the ledger totals above stay accurate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to
a393ff0e4, from an independent review of it. Three real defects — two of themregressions that commit introduced.
Unlike the sync branches, this is an ordinary branch off
main, so the merge button works.1. MAJOR — the override never reached the pipeline that needs it most
a393ff0e4fixed onlyt3x-ci.yml. But the daily sync runs its own verify throughscripts/t3x/sync-upstream.sh($RUN $script→ plainvp run test), and the resolver prompt tellsthe agent to run plain
vp run testtoo.So the next upstream delta would have rebased cleanly, failed verify on the exact test that commit
diagnosed, and escalated as
verify-failed— reopening issue #29's failure class through adifferent door. Threaded through all three call sites.
2. MAJOR —
--testTimeout=60000silently halvedapps/server's budgetapps/server/vite.config.ts:73pinstestTimeout: 120_000, with a comment saying its sqlite + git +orchestration tests "can exceed the default budget on loaded CI hosts". The flag applies to every
package, so 60s cut the heaviest suite in half — the same failure class the override exists to
prevent. Latent (main is green today), but wrong.
apps/webapps/server120000 is the highest value any package configures, so it lowers nothing. The old comment claiming it
"only stops apps/web's override" was simply false, and is corrected.
3. MAJOR — both SEAMS.md churn commands always returned 0
Git's approxidate silently ignores a relative suffix on an absolute date, so
--since="<iso> -60 days"means--since="<iso>"— an empty window.I replaced a wrong-but-working command with two non-working ones. Since the doc says "if the
regenerated ledger and this document disagree, the ledger is right", a literal regeneration would
have zeroed every churn and risk figure in the table. Now uses
--since="@<epoch>"arithmetic, withthe trap documented and a self-check value.
Also
a393ff0e4actually created: merge-baseb64ae880e(not887dd6e45), totals +1468/-112,claude.mdrow +78/-31.the same commit.
a393ff0e4editeddocs/providers/claude.mdand left its row alone, making thedoc wrong the moment it landed. The ledger measures the tree a commit creates.
AGENTS.md's "do not runrepo-wide checks" — a rebase can break any package, so the full suite is the point.
Verification
bash -nclean on the modified script · both workflow YAMLs parse · new churn command returns 59 forChatView (was 0) · every file changed here is fork-owned, so the ledger totals above stay accurate
and no seam row is added.
🤖 Generated with Claude Code