Skip to content

fix(t3x): apply the sync test-timeout to every gate, not just fork CI - #32

Merged
radroid merged 1 commit into
mainfrom
t3x/sync-verify-followup
Jul 30, 2026
Merged

fix(t3x): apply the sync test-timeout to every gate, not just fork CI#32
radroid merged 1 commit into
mainfrom
t3x/sync-verify-followup

Conversation

@radroid

@radroid radroid commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Follow-up to a393ff0e4, from an independent review of it. Three real defects — two of them
regressions that commit introduced.

Unlike the sync branches, this is an ordinary branch off main, so the merge button works.

1. MAJOR — the override never reached the pipeline that needs it most

a393ff0e4 fixed only t3x-ci.yml. But the daily sync runs its own verify through
scripts/t3x/sync-upstream.sh ($RUN $script → plain vp run test), and the resolver prompt tells
the agent to run plain vp run test too.

So the next upstream delta would have rebased cleanly, failed verify on the exact test that commit
diagnosed, and escalated as verify-failedreopening issue #29's failure class through a
different door.
Threaded through all three call sites.

2. MAJOR — --testTimeout=60000 silently halved apps/server's budget

apps/server/vite.config.ts:73 pins testTimeout: 120_000, with a comment saying its sqlite + git +
orchestration tests "can exceed the default budget on loaded CI hosts". The flag applies to every
package, so 60s cut the heaviest suite in half — the same failure class the override exists to
prevent. Latent (main is green today), but wrong.

Package Configured at 60000 at 120000
apps/web 15s 60s ✅ 120s ✅
root 60s 60s 120s ✅
apps/server 120s 60s ⚠️ halved 120s ✅

120000 is the highest value any package configures, so it lowers nothing. The old comment claiming it
"only stops apps/web's override" was simply false, and is corrected.

3. MAJOR — both SEAMS.md churn commands always returned 0

Git's approxidate silently ignores a relative suffix on an absolute date, so
--since="<iso> -60 days" means --since="<iso>" — an empty window.

doc command   → ChatView churn: 0
epoch command → ChatView churn: 59   ✅

I replaced a wrong-but-working command with two non-working ones. Since the doc says "if the
regenerated ledger and this document disagree, the ledger is right"
, a literal regeneration would
have zeroed every churn and risk figure in the table. Now uses --since="@<epoch>" arithmetic, with
the trap documented and a self-check value.

Also

  • SEAMS.md corrected against the tree a393ff0e4 actually created: merge-base b64ae880e (not
    887dd6e45), totals +1468/-112, claude.md row +78/-31.
  • New rule: if a change edits a file with a row in the ledger, update that row and the totals in
    the same commit. a393ff0e4 edited docs/providers/claude.md and left its row alone, making the
    doc wrong the moment it landed. The ledger measures the tree a commit creates.
  • Runbook now records that an upstream sync is the sanctioned exception to AGENTS.md's "do not run
    repo-wide checks" — a rebase can break any package, so the full suite is the point.

Verification

bash -n clean on the modified script · both workflow YAMLs parse · new churn command returns 59 for
ChatView (was 0) · every file changed here is fork-owned, so the ledger totals above stay accurate
and no seam row is added.

🤖 Generated with Claude Code

Follow-up to a393ff0, from an independent review of it. Three real defects,
two of them regressions that commit introduced.

1. The timeout override never reached the pipeline that needs it most.
   a393ff0 fixed only t3x-ci.yml. The daily sync runs its own verify via
   scripts/t3x/sync-upstream.sh (`$RUN $script`, plain `vp run test`), and the
   resolver prompt tells the agent to run plain `vp run test` too. So the next
   upstream delta would rebase cleanly, fail verify on the exact test that was
   just diagnosed, and escalate as `verify-failed` — reopening issue #29's
   class of failure through a different door. Threaded through all three.

2. `--testTimeout=60000` silently HALVED apps/server's budget.
   apps/server/vite.config.ts pins testTimeout: 120_000, with a comment saying
   its sqlite+git+orchestration tests "can exceed the default budget on loaded
   CI hosts". The flag applies to every package, so 60s cut the heaviest suite
   in half — the same failure class the override exists to prevent. Now
   120000, the highest value any package configures, so it lowers nothing:
   web 15s -> 120s, root 60s -> 120s, server 120s -> 120s. The old comment
   claiming it "only stops apps/web's override" was simply false.

3. Both SEAMS.md churn commands always returned 0.
   Git's approxidate silently ignores a relative suffix on an absolute date, so
   `--since="<iso> -60 days"` means `--since="<iso>"` — an empty window. The
   previous wrong-but-working command was replaced with two non-working ones,
   and since the doc says "if the ledger and this document disagree, the ledger
   is right", a literal regeneration would have zeroed every churn and risk
   figure. Now uses `--since="@<epoch>"` arithmetic, with the trap documented
   and a self-check value (ChatView should return ~59, not 0).

Also corrects SEAMS.md against the tree a393ff0 actually created: merge-base
b64ae88 (not 887dd6e), totals +1468/-112, claude.md row +78/-31. That
commit edited a seam file without updating its own row, so a new rule says to
update the row and totals in the same commit — the ledger measures the tree a
commit creates, not the one it started from.

Finally, records in the runbook that an upstream sync is the sanctioned
exception to AGENTS.md's "do not run repo-wide checks" — a rebase can break any
package, so the full suite is the point.

Every file changed here is fork-owned, so the ledger totals above stay accurate.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2364e45c-e437-4977-877e-aa55b1cda3df

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@radroid
radroid merged commit af5a213 into main Jul 30, 2026
3 checks passed
@radroid
radroid deleted the t3x/sync-verify-followup branch July 30, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant