Allow aria-description to describe Dialog and AlertDialog #3658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannikbertram
force-pushed
the
dialogs-allow-aria-description
branch
from
1f1941e to
77f6922
Compare
The aria-description attribute can now be used instead of passing a DialogDescription component as a child or using aria-describedby. A warning is only logged if all of those options are missing.
jannikbertram
force-pushed
the
dialogs-allow-aria-description
branch
from
77f6922 to
945983c
Compare
🦋 Changeset detectedLatest commit: b98b854 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
DialogandAlertDialogcomponents log a warning if neither aDialogDescription/AlertDialogDescriptioncomponent nor a custom component witharia-describedbyattribute is used.It shouldn't be necessary to provide a visible description to a dialog, as some of them can be
self-explanatory.
With this PR, the aria-description is also accepted to provide a description to screen readers.