Skip to content

Conversation

raxod502
Copy link
Member

Close #1167. Remove the default behavior of renaming .el.in files in MELPA recipes as it has been removed upstream. Support :rename (which was added to upstream as a replacement) by translating it in the MELPA recipe fetcher into the cons-cell style renaming that was already supported in straight.el.

Add tests for the modified function, and mock data to support the tests. Change the indentation in the testing code to what Emacs wanted it to be by default, and add linting for the indentation in this file. (The changes are not entirely improvements, but if we want better indentation, we should make sure Emacs is configured to do it properly in this project rather than having it be a personal choice for each contributor.)

@raxod502 raxod502 requested a review from progfolio September 22, 2024 02:24
@raxod502 raxod502 mentioned this pull request Sep 22, 2024
Copy link
Contributor

@progfolio progfolio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Co-authored-by: Nicholas Vollmer <[email protected]>
@raxod502 raxod502 enabled auto-merge September 26, 2024 01:32
@raxod502 raxod502 merged commit 08e197b into develop Sep 26, 2024
4 checks passed
@raxod502 raxod502 deleted the rr-support-melpa-rename branch September 26, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants