Add proper custom host support #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progfolio
reviewed
May 28, 2023
| (let* ((spec (alist-get host straight-hosts)) | ||
| (domain (car spec)) | ||
| (suffix (cadr spec))) | ||
| ;;@FIX: It is sloppy to hardcode the sourcehut case here. |
There was a problem hiding this comment.
Glad to see this hardcoded sourcehut stuff go. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for custom entries in
straight-hostswas previously a bit limited; there were various places in the code where specific built-in hosts had special cases or were hardcoded. This pull request changes the implementation to be fully generic, so that all features that were previously available for built-in hosts are now also available for custom ones. The way we do this is with a new format for thestraight-hostsalist, but the old format is also supported for backwards compatibility (it's automatically translated to the new format if used).This isn't quite done; I'm going to add a few more unit tests to exercise all the added and changed functionality, and also tweak the interface so that it's possible to configure the browser-friendly URL separately from the Git HTTPS URL.