Drop the plugin surface no plugin uses ##analysis - #26702
Open
0verflowme wants to merge 1 commit into
Open
Conversation
RAnalFcnContext with its slot and register-argument records, the get_data_refs plugin hook with its aar merge step and anal.plugins.datarefs setting, and r_anal_types_baselist were added for an external decompiler that has since moved to reading the analysis directly. Nothing in the tree or in that plugin calls them any more, so they go, along with the unit test that only existed to exercise the context collector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes plugin-facing surface that nothing uses any more:
RAnalFcnContext,RAnalFcnSlot,RAnalFcnRegArgandr_anal_function_context_collect/r_anal_function_context_freeget_data_refsplugin hook, itsR_ANAL_PLUGIN_ACTION_GET_DATA_REFSaction, theaarmerge step in core and theanal.plugins.datarefssettingr_anal_types_baselistThese were added for an external decompiler that has since moved to reading the analysis directly through the public API. No plugin in the tree or out of it calls them, so keeping them only widens the ABI. The unit test that existed to exercise the context collector goes with it;
LAjoutput loses theget_data_refskey and the test expectation is updated.Split out of #26646.