Fix n-ary float-complex +/- to not over-eagerly switch to unsafe ops - #1509
Open
samth wants to merge 1 commit into
Open
Fix n-ary float-complex +/- to not over-eagerly switch to unsafe ops#1509samth wants to merge 1 commit into
samth wants to merge 1 commit into
Conversation
The code assumed that just switching to safe ops once was sufficient, but things can be trickier than that. Found by: https://drdr.racket-lang.org/72865/cs/racket/share/pkgs/typed-racket-test/external/tr-random-testing.rkt
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 2 files in this pull request and found no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code assumed that just switching to safe ops once was sufficient,
but things can be trickier than that.
Found by:
https://drdr.racket-lang.org/72865/cs/racket/share/pkgs/typed-racket-test/external/tr-random-testing.rkt