supply missing in metafunction
#110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason to redefine this instead adding an import from |
|
I would vote to putting the definition in place (rather then import) to keep the exposition self-contained up to that point. For someone new to redex it is useful to see it in isolation. |
|
Aftering reading through the tutorial more carefully, I agree. Up to this point in the tutorial, I'll merge this today if there are no objections. |
|
See #112 |
rfindler
pushed a commit
that referenced
this pull request
Jul 16, 2017
(cherry picked from commit 81b440a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtractandsubtract1tests fail becauseinis missing.Note:
inis defined inredex-doc/redex/scribblings/long-tut/code/common.rkt--- but that file is used in a different part of the tutorial. At this point in the tutorial the only import is(require redex).