feat: Get Interface data from NICs that don't have the separate partition info #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
stevekeay
changed the title
We were assuming that every NIC with a partition like Slot.2-1-1 also had a redfish entry for the "base" interface like Slot.2-1, however this is not true on all devices. Some only have the partition-style names. Therefore we change the logic: instead of including only a fixed pattern of NIC names, we ignore any interface that looks like a partition of an existing base NIC.
These sessions age out on their own, but repeatedly calling this code can use up all the sessions on the device, which is annoying because it locks us out.
Fixes a copy-and-paste error in this code
We don't want this polluting stdout, which is what pprint does. We wanted a string, which is what pformat does. In my ignorance I had used the wrong function.
stevekeay
force-pushed
the
nic-partition-names
branch
from
af0c06e to
5c8aeb5
Compare
stevekeay
changed the title
cardoe
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were assuming that every NIC with a partition like Slot.2-1-1 also had a redfish entry for the "base" interface like Slot.2-1, however this is not true on all devices. Some only have the partition-style names. Therefore we change the logic: instead of including only a fixed pattern of NIC names, we ignore any interface that looks like a partition of an existing base NIC.
This currently has issues, because on systems that don't report the shorter names, those names are not recognised when we update the BIOS settings. So perhaps we have to retain the longer names for that purpose.
This in turn is going to be confusing if these inconsistent naming is a result of firmare versions. We would end up with the longer names in nautobot, and then if the firmware is upgraded the names would change. So, potentially the fix is to go for a firmware update before we do any of this. Alternatively, it might be that the differences are due to hardware variation. On the hardware I inspected, I noticed the shorter names were absent on Mellanox NICs, but present on Broadcom ones: