Skip to content

Synthesis Lengths #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Synthesis Lengths #71

wants to merge 3 commits into from

Conversation

@PetrochukM
Copy link
Contributor

@PetrochukM PetrochukM commented May 17, 2018

Conditional synthesis does not respect the lengths parameter, rather it overrides it. This patch fixes that.

@PetrochukM
Lengths
0beda75 
Conditional synthesis does not respect the lengths parameter, rather it overrides it. This patch fixes that.
@PetrochukM PetrochukM changed the title Lengths Synthesis Lengths May 17, 2018
@r9y9
Copy link
Owner

r9y9 commented May 19, 2018

https://github.com/r9y9/wavenet_vocoder#4-synthesize-from-a-checkpoint

--length=: (Un-conditional WaveNet only) Number of time steps to generate.

Well, that was intentional, though. Do you happen to need --length option for conditional synthesis? I'm ok with the change but I would like to make it defaut to synthesize all frames if confitional feature is given.

@PetrochukM
Copy link
Contributor Author

PetrochukM commented May 19, 2018

Yeah. I did read the description.

Given that it takes 20 - 40 minutes at a time to synthesize, I needed the length option just to get a sample from a checkpoint quickly.

r9y9
r9y9 requested changes May 20, 2018
View reviewed changes
Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you address my review and also fix README as well? then LGTM.

synthesis.py
options:
--hparams=<parmas> Hyper parameters [default: ].
--preset=<json> Path of preset parameters (json).
--length=<T> Steps to generate [default: 32000].
Copy link
Owner

@r9y9 r9y9 May 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we drop the default parameter then I don' think

wavenet_vocoder/synthesis.py

Line 146 in 2b557d4

length = int(args["--length"])

will work, since None cannot be converted to int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r9y9 r9y9 r9y9 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PetrochukM @r9y9