Skip to content

Conversation

hadley
Copy link
Member

@hadley hadley commented Aug 8, 2025

Particularly focussing on multiline outputs

Particularly focussing on multiline outputs
@hadley hadley requested a review from gaborcsardi August 8, 2025 18:32
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!

Copy link

claude bot commented Aug 13, 2025

Claude finished @hadley's task —— View job


PR Review - More improvements to match output

  • Analyze main implementation changes in R/expect-match.R
  • Review test files and snapshots for issues
  • Assess UTF-8 concerns from review comments
  • Provide final review feedback

Issue identified: The UTF-8 pipe character (U+2502) in show_text() function at R/expect-match.R:160 could cause cross-platform compatibility issues. While cli::is_utf8_output() provides a fallback to |, the snapshots contain the UTF-8 characters which may fail on non-UTF-8 systems.

Potential fix: Tests should use local_reproducible_output(unicode = FALSE) for snapshot tests to avoid UTF-8 character issues, or add platform-specific snapshot handling.

@hadley hadley merged commit 0c13060 into main Aug 13, 2025
15 of 16 checks passed
@hadley hadley deleted the more-match-improvements branch August 13, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants