Fix subset with glm #50
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix psw behavior when weighted GLMs are profiled via broom::tidy(..., conf.int = TRUE), by changing how psw vectors subset and compare inside downstream glm code paths.
Changes:
- Adds a new
[.pswmethod and explicit comparison-operator methods forpsw. - Adds/updates tests around subsetting, warning behavior, and WeightIt comparisons.
- Registers the new S3 methods, adds
broomtoSuggests, and documents the change inNEWS.md.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
R/psw.R |
Implements the new psw subsetting and comparison behavior. |
tests/testthat/test-bracket-psw.R |
Adds targeted tests for [ behavior and the broom::tidy() regression. |
tests/testthat/test-coercion-warnings.R |
Updates warning expectations for psw comparisons. |
tests/testthat/test-weights.R |
Relaxes WeightIt equality checks to ignore name attributes. |
tests/testthat/test-weights-categorical-comparison.R |
Applies the same name-insensitive comparison updates for categorical-weight tests. |
tests/testthat/_snaps/coercion-warnings.md |
Removes obsolete warning snapshots after the comparison behavior change. |
NAMESPACE |
Registers the new psw S3 operator and [ methods. |
DESCRIPTION |
Adds broom to Suggests for the new regression test. |
NEWS.md |
Records the intended fix and behavior changes for the development version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.