Incoming changes from dependencies#58
Open
llrs-roche wants to merge 4 commits into
Open
Conversation
Contributor
|
Hi @malcolmbarrett , I don't think you need to make any changes to halfmoon. But as we submit cards and gtsummary, CRAN may flag a break in halfmoon between the cards and gtsummary submissions. They may require a resubmission (that is something I have had to do in the past, despite not needing to change anything). |
| # Skip test if suggested package is not present for these tests. | ||
| if (requireNamespace("survey", quietly = TRUE)) { | ||
| q(save = "no") | ||
| } |
Member
There was a problem hiding this comment.
why wouldn't we use testthat::skip_if_not_installed("survey")?
Author
There was a problem hiding this comment.
No reason at all, I went a bit quick to make this change and initially it looked like you weren't using testthat to create tests so I used a plain base R solution. Changed
Member
|
Thanks! Duly noted. I'll keep an eye on word from CRAN before merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
There are some changes on cards, gtsummary and cardx that affect this package.
While at this time we are not sure when we will submit it to CRAN we wanted to give a heads up.
With the versions on github+this PR this package doesn't fail any test or examples or
R CMD check --as-cran.They might be fixed simply when we update all 3 packages but still there is one potential error related to add_ess_header.
Changes on this PR:
You might want to hold on merging this till the mentioned packages are released to CRAN.