Make variable names more verbose and remove comments #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumpohl
commented
Aug 28, 2025
|
|
||
| next_multiple_sp = sp.Piecewise( | ||
| (0, sp.Le(duration, 0)), |
There was a problem hiding this comment.
I compare the duration here directly. Is it faster to compare the integers? I did find a difference in my benchmarks.
Nomos11
reviewed
Aug 28, 2025
|
Oh, I don't think it is syntactically nicer. Just a bit shorter because the quanta do not need to be stored. The important part to me is to avoid non-descriptive variable names unless the meaning is clear in a given domain (loop indices, standardized physical or math notation) |
|
completely agree with the variables; just meant the change from int to float in sp.Le which - it's probably that? - for me made it slower. |
|
that wouldn't make much sense however since that's on evaluation and the instantiation was slower, so idk... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.