Linspace followup waveforms #920
Conversation
Test Results 6 files 6 suites 7m 19s ⏱️ Results for commit 60363e7. ♻️ This comment has been updated with latest results. |
|
|
||
|
|
||
| @property | ||
| def _pow_2_divisor(self) -> int: |
There was a problem hiding this comment.
makes sense; forgot that this is already implemented.
like this or even without accessor?
There was a problem hiding this comment.
I think we do not need to include it in the type system for now. Just add it as a dynamic property.
Question is, how to handle it for the waveform. whould we add a metadata field there as well?
There was a problem hiding this comment.
possibly, but the waveforms are not really used in the public interface anyway, so yagni?
There was a problem hiding this comment.
We will need it to propagate properties like these.
qupulse/program/waveforms.py
Outdated
| @@ -1280,3 +1281,71 @@ def reversed(self) -> 'Waveform': | |||
|
|
|||
| def __repr__(self): | |||
| return f"ReversedWaveform(inner={self._inner!r})" | |||
|
|
|||
|
|
|||
| class WaveformCollection(): | |||
There was a problem hiding this comment.
Do we need WaveformCollection in the main repo?
I thnk it needs a different name and it belongs into a different file. I understand what the class is used for but I do not have a concept of what it actually represents (in terms of nesting). I think it is useful for general command table like devices, but needs more refinement before putting it into the main repo.
with the infamous power 2 hack, but with a test which works