Add typed app environment runtime config#131
Merged
AhmedNMahran merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactors environment selection so
mobile-synccan be published once and configured at runtime for either prelive or production.What changed
AppEnvironmentAPI insync-pipelinesAppEnvironmentdrive both auth and sync defaults togetherBuildKonfig.IS_DEBUGWhy
Before this change:
buildkonfig.flavorSynchronizationEnvironmentWith this change:
AppEnvironment.PRELIVEforces both auth and sync to preliveAppEnvironment.PRODUCTIONforces both auth and sync to productionSynchronizationEnvironment+AuthEnvironmentoverload if neededAPI
Primary API:
Swift:
Advanced override path remains available:
Environment behavior
AppEnvironment keeps auth and sync aligned by default:
PRELIVEauth: https://prelive-oauth2.quran.foundationsync: https://apis-prelive.quran.foundation/authPRODUCTIONauth: https://oauth2.quran.foundationsync: https://apis.quran.foundation/authbuildkonfig.flavoris now only the fallback default when the app does not pass an explicit app environment.Validation
Ran successfully:
xcodebuild \ -project demo/apple/QuranSyncDemo/QuranSyncDemo.xcodeproj \ -scheme QuranSyncDemo \ -destination 'generic/platform=iOS Simulator' \ CODE_SIGNING_ALLOWED=NO \ buildImpact
This is the right shape for downstream consumers such as
quran_androidandquran-ios: