add graphical option to add contacts (create private chats)#871
Draft
MoKe12g wants to merge 4 commits into
Draft
add graphical option to add contacts (create private chats)#871MoKe12g wants to merge 4 commits into
MoKe12g wants to merge 4 commits into
Conversation
refactored openUserInput into openRoomUserInput to make it clear, what this function does added NoRoomJoining into openRoomAction to make it clear, what the function is intended to do
KitsuneRal
requested changes
May 23, 2023
KitsuneRal
left a comment
KitsuneRal
left a comment
Member
There was a problem hiding this comment.
Thanks, and sorry for taking time to review. The existing Open room... dialog supports entering user ids too. Besides, Open room... supports matrix: URIs and matrix.to URLs. I recognise it's not quite discoverable - happy to get suggestions how to improve that. I can understand that having a separate dialog restricted to user ids might be the best solution - but then please extend openUserInput() instead of duplicating most of its code. Turning a bool parameter to an enum and having two or three extra conditionals is totally fine for that matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to the menu to create a private chat as wished in #845.