Skip to content

Improved scrollindicators#120

Open
maralorn wants to merge 3 commits into
quotient-im:devfrom
maralorn:improved-scrollindicators
Open

Improved scrollindicators#120
maralorn wants to merge 3 commits into
quotient-im:devfrom
maralorn:improved-scrollindicators

Conversation

@maralorn

@maralorn maralorn commented Nov 5, 2016

Copy link
Copy Markdown
Contributor

This should only be merged after @KitsuneRal ’s readmarker handling and my activity-detector change.

For the rest see commit message

@AppVeyorBot

Copy link
Copy Markdown

@maralorn

maralorn commented Nov 5, 2016

Copy link
Copy Markdown
Contributor Author

Please feel free to comment on the design. I don’t think it’s perfect.

This builds on top of the changs from @KitsuneRal
The ActivityDetector is now only enabled, when really needed.
This should fix quotient-im#104
This will show scrollindicators to the top and to the bottom with
explanations, when there are unread messages in that direction
@maralorn maralorn force-pushed the improved-scrollindicators branch from 1073f7f to 78a2ca7 Compare November 6, 2016 11:05
@AppVeyorBot

Copy link
Copy Markdown

@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Dec 20, 2017
@maralorn

maralorn commented Nov 6, 2020

Copy link
Copy Markdown
Contributor Author

I assume this PR has bitrotten enough to just close it?

It's great to see, that Quaternion is still going strong, but obviously my focus has shifted.

@KitsuneRal

Copy link
Copy Markdown
Member

Nope, still has enough useful code so I keep it around. Thanks for contributing back then :)

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A feature or change request for Quaternion

Projects

Status: 0.x - To Do

Development

Successfully merging this pull request may close these issues.

3 participants