using the same path ID, also for PATH_RESPONSE #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+331
to
+333
| received by the server. If an endpoint receives a PATH_CHALLENGE, the | ||
| PATH_RESPONSE MUST be sent on the same path as the packet that contained | ||
| the PATH_CHALLENGE frame. |
There was a problem hiding this comment.
Isn't it the case that you need to send these packets? Should that follow the "MUST validate" clause in the next paragraph instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #546
Proposed rewrite by @huitema to make it more clear that using the same path does not automatically imply sending a PATH_RESPONSE