Add read-only index support - #730
Draft
shashankbrgowda wants to merge 1 commit into
Draft
Conversation
Author
|
Sorry for the AI generated PR. There is currently no equivalent in tantivy-py to the custom directory workaround described in quickwit-oss/tantivy#557 (comment) because the Python bindings do not expose Tantivy’s Directory trait. I opened quickwit-oss/tantivy#3058 to add read-only index support in Tantivy. This draft demonstrates how that API could be exposed through tantivy-py. This would be useful for Python applications that use pre built tantivy indexes from read-only filesystem I explained the fastapi use case here quickwit-oss/tantivy#557 (comment) |
Collaborator
|
This sounds fine. If upstream merges the upstream PR, I'm fine to merge this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft adds
Index.open_read_only(path)for opening immutable indexes without acquiring the metadata lock.It depends on quickwit-oss/tantivy#3058 and the Tantivy 0.27 upgrade in
tantivy-py. The temporary fork dependency will be removed before this PR is ready.Built with GPT-5.6 Sol in the Codex desktop harness. Codex helped implement and review the binding and test. I reviewed and understand the submitted changes.