fix(indexing): align sequencer capacity with upload concurrency - #6790
Open
dayaffe wants to merge 1 commit into
Open
fix(indexing): align sequencer capacity with upload concurrency#6790dayaffe wants to merge 1 commit into
dayaffe wants to merge 1 commit into
Conversation
Contributor
Author
|
/ci-run-all-tests |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
pront
approved these changes
Sep 9, 2026
fulmicoton
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6312
Description
Makes the sequencer mailbox capacity configurable and sizes it according to each pipeline’s configured concurrent upload limit.
Previously, every sequencer used a fixed mailbox capacity of two. Because uploaders reserve a position in the sequencer before starting an upload, this unintentionally limited each pipeline to three concurrent uploads, regardless of the configured upload concurrency.
The change covers the standard indexing pipeline, Parquet indexing pipeline, and Parquet merge pipeline. It also updates the indexing pipeline diagram to document the new relationship.
How was this PR tested?
quickwit-indexingunit tests successfully with a single test thread.cargo clippywith warnings treated as errors.make fmt.