Fix regression in 0.10.x: fix type for is_detached #1123
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
reviewed
Jul 16, 2025
| @@ -374,7 +374,7 @@ typedef struct JSVarRef { | |||
| struct { | |||
| int __gc_ref_count; /* corresponds to header.ref_count */ | |||
| uint8_t __gc_mark; /* corresponds to header.mark/gc_obj_type */ | |||
| bool is_detached; | |||
| uint8_t is_detached; | |||
There was a problem hiding this comment.
Ah... do IUC that sizeof(bool) > sizeof(char) on ppc?
There was a problem hiding this comment.
Bool is 4 bytes in ppc ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes regression in 0.10.0, see: #1122
Subsequent segfault still remains, but it also happens with 0.9.0 and 0.8.0.
@andrjohns @bnoordhuis