Skip to content

fix oob bug in malformed header #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krypdkat wants to merge 1 commit into from
Closed

fix oob bug in malformed header #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ int QubicConnection::receiveData(uint8_t* buffer, int sz)

int QubicConnection::receiveAllDataOrThrowException(uint8_t* buffer, int sz)
{
if (sz < 0 || sz > (int)sizeof(mBuffer)) {

@Franziska-Mueller Franziska-Mueller Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a more appropriate place for this check because the checked mBuffer is not used in the code.

@krypdkat krypdkat Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then it should be 0xffffff, can mBuffer be removed btw?

throw std::logic_error("Invalid packet size.");
}
int recvSz = receiveData(buffer, sz);
if (recvSz != sz)
{
Expand Down
Loading