docs(#70): add skillsaw pip fallback to AGENTS.md - #71
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#70): add skillsaw pip fallback to AGENTS.md#71fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Document that agents should install and run skillsaw via pip when Docker is unavailable in the sandbox, rather than skipping lint entirely. This prevents CI failures from baseline mismatches going undetected until a human intervenes. Adds section 7 "Linting (skillsaw)" covering: - pip install + skillsaw --strict as the native fallback - skillsaw baseline for updating .skillsaw-baseline.json - Guidance to not suppress warnings by modifying unrelated lines Closes #70
|
🤖 Finished Review · ✅ Success · Started 1:30 AM UTC · Completed 1:43 AM UTC Commit: |
ReviewFindingsMedium
Labels: PR adds agent guidance documentation to AGENTS.md |
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install skillsaw && skillsaw --strictas the native alternative tomake lintskillsaw baselinefor updating.skillsaw-baseline.jsonwhen pre-existing violations are encounteredContext
On PR #66, the code agent attempted
make lintwhich runs skillsaw in a Docker container. Docker is not available in the agent sandbox, so the agent skipped lint entirely. CI then failed due to a baseline mismatch. A fix agent later discovered the pip approach works natively. This change ensures future agents have the guidance to run skillsaw directly.Testing
skillsaw --strictruns successfully afterpip install skillsawin the sandboxCloses #70
Post-script verification
agent/70-skillsaw-lint-docs)952caf9bec9a3e23aa2d07aae9488d110c1de27c..HEAD)