Skip to content

Warn when using deprecated configurations #48660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

radcortez
Copy link
Member

We used to warn when using deprecated configuration. This was only for the old @ConfigRoot, so when we moved to @ConfigMapping, we lost the warnings.

This PR adds the warnings for @Deprecated properties in @ConfigMapping and remove the old code for @ConfigRoot. We may miss warnings for @ConfigRoot, but we already have a warning for users to migrate to @ConfigMapping, which would reenable the feature.

@radcortez radcortez force-pushed the deprecated-mapped-properties branch from 642b905 to 9faa60a Compare June 27, 2025 15:32
Copy link

quarkus-bot bot commented Jun 27, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 642b905.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview ab90e24 has been successfully built and deployed to https://quarkus-pr-main-48660-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Jun 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9faa60a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

  • Too many recursions, message not returned for id [134981005] - java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [134981005]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:168)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)

@gsmet gsmet merged commit 2f711bf into quarkusio:main Jul 1, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 1, 2025
@gsmet
Copy link
Member

gsmet commented Jul 1, 2025

I wonder if we should also have a way to report relocated properties as deprecated?

Because we sometimes use this infra to handle deprecations and maybe we need a way to declare that a given relocation class is handling deprecated properties?

And my understanding is that we could get both the deprecated property and the new one in this case?

Note that not all relocations are related to deprecations.

@radcortez
Copy link
Member Author

Yes, let's improve this. This was just to add the missing functionality to mappings. Now with the doc work, we can iterate and improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants