Skip to content

Extend include_tags to support by-type selection #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 16, 2025

Conversation

WingCode
Copy link
Contributor

implements #2905 based on the comments here.
closed previous PR #7415

@WingCode WingCode requested review from wcourtney, vtomole, verult and a team as code owners June 14, 2025 00:40
@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 14, 2025
@WingCode
Copy link
Contributor Author

@mhucka
Would you mind assigning one of the reviewers to take a look at this PR when possible? Thank you!

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (bb7b5c1) to head (4d7b4af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7425      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       97910    97937      +27     
==========================================
+ Hits        96632    96658      +26     
- Misses       1278     1279       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka self-assigned this Jun 15, 2025
@mhucka
Copy link
Contributor

mhucka commented Jun 15, 2025

@mhucka Would you mind assigning one of the reviewers to take a look at this PR when possible? Thank you!

I assigned myself, at least for the weekend, since other people may not be available until Monday.

@mhucka mhucka removed their assignment Jun 16, 2025
@pavoljuhas pavoljuhas changed the title Extend include tag selection to have subset values Extend include_tags to support by-type selection Jun 16, 2025
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@pavoljuhas pavoljuhas enabled auto-merge June 16, 2025 20:08
@pavoljuhas pavoljuhas added this pull request to the merge queue Jun 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 16, 2025
@pavoljuhas pavoljuhas added this pull request to the merge queue Jun 16, 2025
Merged via the queue into quantumlib:main with commit 9d511e9 Jun 16, 2025
63 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250 unitaryHACK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants