Skip to content

Combining readout circuits for QWC pauli strings in the measure_pauli_strings method #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ddddddanni
Copy link
Contributor

@ddddddanni ddddddanni commented Jun 11, 2025

PR #7236 adds the feature to measure groups of qubit-wise-commuting Pauli operators simultaneously.

However, the current implementation generates a separate readout circuit for each individual Pauli operator within a group. This leads to non-simultaneous measurements, which is corrected in this PR.

@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 11, 2025
@github-actions github-actions bot added size: S 10< lines changed <50 and removed size: M 50< lines changed <250 labels Jun 11, 2025
@github-actions github-actions bot added size: M 50< lines changed <250 and removed size: S 10< lines changed <50 labels Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (8788b62) to head (624b309).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7416      +/-   ##
==========================================
- Coverage   98.69%   98.68%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       97769    97780      +11     
==========================================
+ Hits        96491    96499       +8     
- Misses       1278     1281       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddddddanni ddddddanni marked this pull request as ready for review June 11, 2025 17:02
@ddddddanni ddddddanni requested review from vtomole and a team as code owners June 11, 2025 17:02
Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks, @ddddddanni! Tested in this colab.

@ddddddanni
Copy link
Contributor Author

Works great! Thanks, @ddddddanni! Tested in this colab.

Thank you!! I will wait for Nour to give a stamp and submit this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants