-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support merge symbolized 1 qubit gate transformer #7393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c283401
to
85586b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7393 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 1112 1112
Lines 97921 98004 +83
=======================================
+ Hits 96639 96725 +86
+ Misses 1282 1279 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@NoureldinYosri @eliottrosenberg I re-synced and refactored #7149 here, re-review calls! Thank you! And thank you Nour for noticing this and self assigning! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in this colab and got an error.
Good catch!! I should align the circuit after the parameterization. Patched. Could you help take another look? @eliottrosenberg |
…ched circuit structures in parameterizations
I also added unit tests by calling gauge_compiling.as_sweep as input similar to the colab: test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you, @babacry!
Merge single qubit gates for symbolized circuits.
It is a updated version of #7149 where tag_transformers and symbolize transformers are already merged.