Skip to content

docs(react): update listbox docs demos - #349

Draft
Nitin (49-22) wants to merge 2 commits into
devfrom
fix/listbox-input-navigation
Draft

docs(react): update listbox docs demos#349
Nitin (49-22) wants to merge 2 commits into
devfrom
fix/listbox-input-navigation

Conversation

@49-22

@49-22 Nitin (49-22) commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • Updates the React Listbox filtering demo with more region mock data.
  • Adds a scrollable content area to the filtering demo using className="max-h-64 overflow-y-auto".
  • Adds a dynamic data loading demo that keeps Listbox.Content mounted while loading, empty, and loaded states render inside it.

Context

Reviewer feedback clarified that Listbox.Content is expected to always remain mounted, even when no options are available. This PR no longer changes core Listbox keyboard behavior for an initially unmounted content case. Instead, it documents the intended async-data pattern in the React docs.

Testing

pnpm react-docs lint

@R-Bower

Ryan Bower (R-Bower) commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

The listbox content should always be rendered, even if there are no options available. Also, I was not able to reproduce this bug.

image

@R-Bower

Ryan Bower (R-Bower) commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Reopening: Nitin (@49-22) can you post a reproduction? I was unable to reproduce this. If the test reproduction is only possible with Listbox.Content unmounted initially, then this can be closed. Listbox.Content should always be mounted.

@49-22

Nitin (49-22) commented Aug 27, 2026

Copy link
Copy Markdown
Author

Yes, it’s reproducible only when Listbox.content is not mounted initially yet

how about keeping an example to ensure even an uninformed AI agent or dev can avoid wasting time in debugging it.

@49-22 Nitin (49-22) changed the title fix(listbox): support input navigation before content mounts docs(react): update listbox docs demos Aug 27, 2026
@49-22
Nitin (49-22) force-pushed the fix/listbox-input-navigation branch from dea9920 to a7095cb Compare August 27, 2026 08:48
  mounts

Signed-off-by: Nitin <nitin.nagamalla@gmail.com>
Signed-off-by: Nitin <nitin.nagamalla@gmail.com>
@49-22
Nitin (49-22) force-pushed the fix/listbox-input-navigation branch from a7095cb to 928c7f0 Compare August 27, 2026 08:56
@49-22

Copy link
Copy Markdown
Author

Ryan Bower (@R-Bower) Updated the examples to ensure what I missed is not missed by anyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants